Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: for UNION statements, ORDER BY cannot use column references including a table name (#8389) #8514

Merged
merged 4 commits into from
Dec 13, 2018
Merged

planner: for UNION statements, ORDER BY cannot use column references including a table name (#8389) #8514

merged 4 commits into from
Dec 13, 2018

Conversation

dbjoa
Copy link
Contributor

@dbjoa dbjoa commented Nov 29, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Cherry-pick from #8389 to release-2.0 branch

This change is Reviewable

@dbjoa
planner: for UNION statements, ORDER BY cannot use column references …
989d39b 
…including a table name (#8389)
@dbjoa
planner: for UNION statements, ORDER BY cannot use column references …
de2be30 
…including a table name (#8389)

# Conflicts:
#	cmd/explaintest/r/explain_easy.result
#	plan/errors.go
#	plan/expression_rewriter.go
#	plan/logical_plan_builder.go
#	plan/physical_plan_test.go
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shenli shenli added contribution This PR is from a community contributor. type/2.0 cherry-pick labels Nov 29, 2018
@zz-jason
Copy link
Member

@dbjoa CI failed.

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Nov 29, 2018
@ngaut
Copy link
Member

ngaut commented Dec 12, 2018

/run-all-tests

@ngaut
Copy link
Member

ngaut commented Dec 12, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

eurekaka
eurekaka reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Dec 13, 2018
zz-jason
zz-jason approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 240fd12 into pingcap:release-2.0 Dec 13, 2018
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dbjoa @sre-bot @zz-jason @ngaut @eurekaka @shenli